BREAKING: connection.ini: replaces ... #3435
Merged
+157
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haproxy_hosts, ehlo_hello_message, connection_close_message, banner_includes_uuid, deny_includes_uuid, databytes, max_mime_parts, max_line_length, max_data_line_length, and smtpgreeting. To upgrade, apply any localized settings from the old config files to the new connection.ini file and for tidiness, delete the old config files. - moved the following settings from smtp.ini to connection.ini: - headers.* - main.smtp_utf8 - main.strict_rfc1869 - early_talker.pause, removed support, use earlytalker.ini
msimerson
force-pushed
the
connection.ini
branch
from
8cab8ff to
b7b4e7c
Compare
msimerson
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
connection.inireplaces the following config files:AND
To upgrade, apply any localized settings from the old config files to the new
connection.inifile. For tidiness, delete the deprecated config files.Fixes #3434
Checklist:
Commentary
This is a bit of a break from tradition in that Haraka has historically been loathe to ever deprecate a config file. We've jumped through hoops to assure that old config files remained working unless we bumped a major version, which also meant legacy config files were almost never dropped.
This state of affairs has been bad for discoverability as well as having documentation (when existent) for the settings scattered about. This PR consolidates a bunch of settings that are only ever used within a connection, moves the documentation for the settings into the config file next to the knobs that can be twiddled, deprecates the necessity of passing
smtp.iniinto connections, and improves the consistency of the implementations.